-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add published decade filter option #3489
Conversation
Working great, nice and clean, thanks! The projects formatting options are setup for vscode and should automatically remove semicolons on save. If you're not using vscode the .prettierrc and .editorconfig files might be able to work with your code editor to auto apply our formatting settings. |
I am using VS Code, so that's weird it didn't remove the semicolons automatically. I'll have to check that there isn't something that I misconfigured. |
Thank you, @glorenzen! I totally agree that your solution is better than my proposal. I wasn't sure how "Published Decade" would look with all the other single-word items in that last, but I clearly chose poorly, as it looks great! |
Minor nit, I have a single book for which the published year is |
This adds a library filter option for Published Decade and resolves #3448
It doesn't follow the same format as the images in the issue, but I thought "Published Decade" was more descriptive and user-friendly than just "Published" in the top list with "Decade XXXX" in the sublist.
Everything seems to be working on my end, but there may be something I'm missing.